Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable cancel button if there is a latching failure #942

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Disable cancel button if there is a latching failure #942

merged 4 commits into from
Apr 30, 2024

Conversation

aaronchongth
Copy link
Member

What's new

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

@aaronchongth
Disable cancel button if there is a latching failure
b8068a8 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Cleaner separation for latching related delivery alert
5537895 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Apr 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 13.32%. Comparing base (fe0e808) to head (5537895).
Report is 83 commits behind head on deploy/hammer.

❗ Current head 5537895 differs from pull request most recent head 5d3ae8f. Consider uploading reports for the commit 5d3ae8f to get more accurate results

Files Patch % Lines
.../dashboard/src/components/delivery-alert-store.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@                Coverage Diff                 @@
##           deploy/hammer     #942       +/-   ##
==================================================
- Coverage          49.35%   13.32%   -36.03%     
==================================================
  Files                285       67      -218     
  Lines               7564     3106     -4458     
  Branches            1050      910      -140     
==================================================
- Hits                3733      414     -3319     
+ Misses              3682     2686      -996     
+ Partials             149        6      -143
Flag Coverage Δ
api-server ?
dashboard 13.32% <0.00%> (-1.74%) ⬇️
react-components ?
rmf-auth ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aaronchongth
Refactor delivery action response route, to log user action
32380c3 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Lint
5d3ae8f 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
xiyuoh
xiyuoh approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@xiyuoh xiyuoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaronchongth aaronchongth merged commit 78574d5 into deploy/hammer Apr 30, 2024
3 of 4 checks passed
@aaronchongth aaronchongth deleted the hammer/disable-latching-cancel branch April 30, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiyuoh xiyuoh xiyuoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronchongth @xiyuoh